Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fix markdown loader on Windows #34623

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

michaldudak
Copy link
Member

Changes introduced in #34243 made it impossible to run components docs locally on Windows due to differences in path delimiters.
This PR fixes the problem by replacing backslashes with slashes and recognizing the : character after a drive letter.

@michaldudak michaldudak added the core Infrastructure work going on behind the scenes label Oct 5, 2022
@mui-bot
Copy link

mui-bot commented Oct 5, 2022

No bundle size changes

Generated by 🚫 dangerJS against 6d5269f

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@michaldudak michaldudak merged commit 1e09429 into mui:master Oct 5, 2022
@michaldudak michaldudak deleted the markdown-loader-windows-fix branch October 5, 2022 12:47
alexfauquette pushed a commit to alexfauquette/material-ui that referenced this pull request Oct 14, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants