-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] Link respective repositories in product pages #35046
Conversation
modified AppHeader.tsx to detect the current product and link the github icon to the appropriate repository
|
@oliviertassinari can you have a look at this? I have removed concatenation as you suggested. |
@sidtohan Thanks, I have pushed a few changes with the goal to simplify the implementation. It seems that we can give control to the page that renders these components. I think it's simpler (e.g. won't break when the URL changes) but it's not for me to carry forward so I'm leaving the PR. I'm adding as reviewers the two people that were involved in the GitHub issue. If we move forward with this approach, this will need to be updated: https://github.com/mui/mui-toolpad/blob/213103a8b1dd1a877939b083fb833aeef35e2ec1/docs/pages/toolpad/index.js#L41. @bharatkashyap Could you take care of it? Thanks cc @Janpot who raised the confusion during a Toolpad's meeting. |
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Fixes #34336
A continuation of #34889