-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][base] Add return type for useFormControlUnstyledContext
hook
#36302
Merged
ZeeshanTamboli
merged 9 commits into
mui:master
from
HeVictor:add-interface-for-use-form-control-unstyled-context-hook
Apr 3, 2023
Merged
[docs][base] Add return type for useFormControlUnstyledContext
hook
#36302
ZeeshanTamboli
merged 9 commits into
mui:master
from
HeVictor:add-interface-for-use-form-control-unstyled-context-hook
Apr 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se-form-control-unstyled-context-hook
…se-form-control-unstyled-context-hook
Netlify deploy previewhttps://deploy-preview-36302--material-ui.netlify.app/ Bundle size report |
packages/mui-base/src/FormControlUnstyled/FormControlUnstyled.types.ts
Outdated
Show resolved
Hide resolved
ZeeshanTamboli
added
docs
Improvements or additions to the documentation
typescript
component: FormControl
The React component
labels
Mar 30, 2023
This was referenced Mar 30, 2023
ZeeshanTamboli
changed the title
Add interface for useFormControlUnstyledContext hook
[docs][base] Add return type for Apr 3, 2023
useFormControlUnstyledContext
hook
ZeeshanTamboli
approved these changes
Apr 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the required changes. @HeVictor Thanks for the PR!
Thanks for making the changes @ZeeshanTamboli! Was very busy lately so couldn't address those comments myself so really appreciate the help. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: FormControl
The React component
docs
Improvements or additions to the documentation
typescript
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds useFormControlUnstyledContext hook return value interface for #35933.
PR is a draft because I'm unable to generate any docs at the moment just by using
FormControlUnstyledState | undefined
as the return value for the hook and wanted to clarify next steps. Should I simply deconstructFormControlUnstyledState
and enter each of its properties separately intoUseFormControlUnstyledContextReturnValue
so that docs can be generated?