Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][base] Add return type for useFormControlUnstyledContext hook #36302

Conversation

HeVictor
Copy link
Contributor

Adds useFormControlUnstyledContext hook return value interface for #35933.

PR is a draft because I'm unable to generate any docs at the moment just by using FormControlUnstyledState | undefined as the return value for the hook and wanted to clarify next steps. Should I simply deconstruct FormControlUnstyledState and enter each of its properties separately into UseFormControlUnstyledContextReturnValue so that docs can be generated?

@mui-bot
Copy link

mui-bot commented Feb 22, 2023

Netlify deploy preview

https://deploy-preview-36302--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 6cb46c7

@ZeeshanTamboli ZeeshanTamboli added docs Improvements or additions to the documentation typescript component: FormControl The React component labels Mar 30, 2023
@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review April 3, 2023 11:10
@ZeeshanTamboli ZeeshanTamboli changed the title Add interface for useFormControlUnstyledContext hook [docs][base] Add return type for useFormControlUnstyledContext hook Apr 3, 2023
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the required changes. @HeVictor Thanks for the PR!

@ZeeshanTamboli ZeeshanTamboli merged commit 6566cce into mui:master Apr 3, 2023
@HeVictor
Copy link
Contributor Author

HeVictor commented Apr 3, 2023

Thanks for making the changes @ZeeshanTamboli! Was very busy lately so couldn't address those comments myself so really appreciate the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: FormControl The React component docs Improvements or additions to the documentation typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants