-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][base] Improve the Slots Table in API docs #36330
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbjORbj
added
docs
Improvements or additions to the documentation
package: base-ui
Specific to @mui/base
labels
Feb 25, 2023
Netlify deploy previewhttps://deploy-preview-36330--material-ui.netlify.app/ Bundle size report |
michaldudak
reviewed
Feb 27, 2023
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Mar 2, 2023
1 task
hbjORbj
force-pushed
the
base/slot-description
branch
from
March 15, 2023 10:27
c5149d6
to
d7c2dea
Compare
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Mar 15, 2023
hbjORbj
force-pushed
the
base/slot-description
branch
from
March 15, 2023 10:34
d7c2dea
to
e11a82a
Compare
michaldudak
reviewed
Mar 16, 2023
docs/translations/translations.json
Outdated
@@ -31,7 +32,7 @@ | |||
"slots": "Slots", | |||
"spreadHint": "Props of the {{spreadHintElement}} component are also available.", | |||
"styleOverrides": "The name <code>{{componentStyles.name}}</code> can be used when providing <a href={{defaultPropsLink}}>default props</a> or <a href={{styleOverridesLink}}>style overrides</a> in the theme.", | |||
"slotDescription": "You can use this slot in <code>slotProps</code> prop or in <code>extendTheme</code> function to customize its style or <a href={{extendVariantsLink}}>extend variants</a>.", | |||
"slotDescription": "To learn how to customize the slot, check out this guide--<a href={{slotGuideLink}}>Overriding component structure</a>.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
"slotDescription": "To learn how to customize the slot, check out this guide--<a href={{slotGuideLink}}>Overriding component structure</a>.", | |
"slotDescription": "To learn how to customize the slot, check out the <a href={{slotGuideLink}}>Overriding component structure</a> guide.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, addressed!
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Mar 17, 2023
hbjORbj
force-pushed
the
base/slot-description
branch
from
March 17, 2023 14:00
34b6ab0
to
127cb07
Compare
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR's motivation is to keep consistency with Joy. (Relevant PR: #36328), on which This PR is on top of. The independently relevant commits for Base are the last 4 commits.
Preview: https://deploy-preview-36330--material-ui.netlify.app/base/api/badge-unstyled/#slots