Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][base] Improve the Slots Table in API docs #36330

Merged
merged 2 commits into from
Mar 17, 2023

Conversation

hbjORbj
Copy link
Member

@hbjORbj hbjORbj commented Feb 25, 2023

This PR's motivation is to keep consistency with Joy. (Relevant PR: #36328), on which This PR is on top of. The independently relevant commits for Base are the last 4 commits.

Preview: https://deploy-preview-36330--material-ui.netlify.app/base/api/badge-unstyled/#slots

@hbjORbj hbjORbj added docs Improvements or additions to the documentation package: base-ui Specific to @mui/base labels Feb 25, 2023
@hbjORbj hbjORbj self-assigned this Feb 25, 2023
@hbjORbj hbjORbj added this to the MUI Base stable release milestone Feb 25, 2023
@mui-bot
Copy link

mui-bot commented Feb 25, 2023

Netlify deploy preview

https://deploy-preview-36330--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 127cb07

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 2, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 15, 2023
@@ -31,7 +32,7 @@
"slots": "Slots",
"spreadHint": "Props of the {{spreadHintElement}} component are also available.",
"styleOverrides": "The name <code>{{componentStyles.name}}</code> can be used when providing <a href={{defaultPropsLink}}>default props</a> or <a href={{styleOverridesLink}}>style overrides</a> in the theme.",
"slotDescription": "You can use this slot in <code>slotProps</code> prop or in <code>extendTheme</code> function to customize its style or <a href={{extendVariantsLink}}>extend variants</a>.",
"slotDescription": "To learn how to customize the slot, check out this guide--<a href={{slotGuideLink}}>Overriding component structure</a>.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"slotDescription": "To learn how to customize the slot, check out this guide--<a href={{slotGuideLink}}>Overriding component structure</a>.",
"slotDescription": "To learn how to customize the slot, check out the <a href={{slotGuideLink}}>Overriding component structure</a> guide.",

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, addressed!

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 17, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 17, 2023
@hbjORbj hbjORbj merged commit 6608eb1 into mui:master Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants