[useMenu][base] Add return interface for useMenu hook #36376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ircular dependency problem
Netlify deploy previewhttps://deploy-preview-36376--material-ui.netlify.app/ Bundle size report |
HeVictor
commented
Feb 28, 2023
| export interface MenuItemState { | ||
| disabled: boolean; | ||
| highlighted: boolean; | ||
| } |
There was a problem hiding this comment.
Call-out that I had to refactor these types from useMenu.types.ts as a circular dependency error was occurring between the newly added UseMenuReturnValue type within useMenu.type.ts as that interface imported from MenuUnstyledContext.ts which in turn imported the above two types from useMenu.type.ts.
There was a problem hiding this comment.
Let's move these types into src/MenuItemUnstyled/MenuItemUnstyled.types.ts
There was a problem hiding this comment.
Thanks for the review. Have amended PR
zannager
added
the
component: menu
samuelsycamore
changed the title
hbjORbj
suggested changes
Mar 2, 2023
| export interface MenuItemState { | ||
| disabled: boolean; | ||
| highlighted: boolean; | ||
| } |
There was a problem hiding this comment.
Let's move these types into src/MenuItemUnstyled/MenuItemUnstyled.types.ts
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
15 tasks
hbjORbj
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds return interface for
useMenufor #35933