Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add multiline Chip example #36437

Merged
merged 5 commits into from
Mar 15, 2023
Merged

[docs] Add multiline Chip example #36437

merged 5 commits into from
Mar 15, 2023

Conversation

dav1app
Copy link
Contributor

@dav1app dav1app commented Mar 5, 2023

This adds a basic example on the docs regarding multilined chips.

It's a known issue regarding Autocomplete (#15185) and generic Chip (#14864).

https://stackoverflow.com/questions/61385380/material-ui-autocomplete-chip-multiline.

Alternative solutions are:

  • Chip component should export labelProps, like labelProps.
  • Multiline chips should be the default behaviour.

@mui-bot
Copy link

mui-bot commented Mar 5, 2023 •
edited
Loading

Netlify deploy preview

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 5745943

@hbjORbj hbjORbj added docs Improvements or additions to the documentation component: chip This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Mar 6, 2023
@zannager zannager requested a review from siriwatknp March 7, 2023 07:41
@danilo-leal danilo-leal changed the title [docs]: multiline chip example [docs] Add multiline Chip example Mar 15, 2023
danilo-leal
danilo-leal approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thanks for contributing 👌

@danilo-leal danilo-leal merged commit e592629 into mui:master Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilo-leal danilo-leal danilo-leal approved these changes

@siriwatknp siriwatknp Awaiting requested review from siriwatknp

Assignees
No one assigned
Labels
component: chip This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dav1app @mui-bot @danilo-leal @hbjORbj