[autocomplete] Allow tooltip text selection #36503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-36503--material-ui.netlify.app/ Bundle size report |
zannager
added
the
component: autocomplete
mnajdova
changed the title
mnajdova
changed the title
|
I was trying to write an other test to check the user's onMouse text highlight/selection behavior but was not successful. |
| @@ -1007,13 +1007,25 @@ export default function useAutocomplete(props) { | |||
|
|
|||
| // Prevent input blur when interacting with the combobox | |||
| const handleMouseDown = (event) => { | |||
| const isToolTipElement = event.target?.parentElement?.getAttribute('role')?.includes('tooltip'); | |||
There was a problem hiding this comment.
I think that this check is too specific.
There was a problem hiding this comment.
Yes, see totally your point.
I'm working on it and looking at that other issues.
There was a problem hiding this comment.
But regards to this issue only, I made a change.
There was a problem hiding this comment.
@oliviertassinari in case you missed it, I just made it general in a way that if user clicks anywhere outside the Autocomplete component, it prevents focusing. so then user is able to select text for instance.
safeamiiir
requested review from
oliviertassinari
and removed request for
mnajdova
mnajdova
requested review from
michaldudak
and removed request for
oliviertassinari
mnajdova
approved these changes
Apr 12, 2023
binh1298
pushed a commit
to binh1298/material-ui
that referenced
this pull request
May 17, 2023
Co-authored-by: Amirreza safehian <amirreza@RIV-D421TWWQ9V.local>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #33195
Codesandbox: https://codesandbox.io/s/inputadornments-demo-material-ui-forked-j0gvpo?file=/demo.tsx