Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][base] Move styles to the bottom of demos code for ModalUnstyled #36580

Merged
merged 5 commits into from
Apr 12, 2023
Merged

[docs][base] Move styles to the bottom of demos code for ModalUnstyled #36580

merged 5 commits into from
Apr 12, 2023

Conversation

gitstart
Copy link
Contributor

@gitstart gitstart commented Mar 20, 2023 •
edited by oliviertassinari
Loading

One part of #36498

This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.

@gitstart @seunexplicit
feat: [docs][base][Modal] Move styles to the bottom of demos code
48812ad 
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
@mui-bot
Copy link

mui-bot commented Mar 20, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-36580--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 60796e0

@gitstart gitstart marked this pull request as ready for review March 20, 2023 08:55
@gitstart
Copy link
Contributor Author

@michaldudak this PR is ready for review

@zannager zannager added docs Improvements or additions to the documentation component: modal This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base labels Mar 20, 2023
@hbjORbj hbjORbj changed the title MUI-36498 - [docs][base][Modal] Move styles to the bottom of demos code [docs][base] Move styles to the bottom of demos code for Modal Mar 20, 2023
@ZeeshanTamboli ZeeshanTamboli mentioned this pull request Mar 31, 2023
Closed
13 tasks
@ZeeshanTamboli
Update docs/data/base/components/modal/KeepMountedModal.tsx
c572b31 
Signed-off-by: Zeeshan Tamboli <zeeshan.tamboli@gmail.com>
@ZeeshanTamboli
Update docs/data/base/components/modal/KeepMountedModal.js
f107bb9 
Signed-off-by: Zeeshan Tamboli <zeeshan.tamboli@gmail.com>
@ZeeshanTamboli ZeeshanTamboli changed the title [docs][base] Move styles to the bottom of demos code for Modal [docs][base] Move styles to the bottom of demos code for ModalUnstyled Apr 3, 2023
@mnajdova
Update NestedModal.tsx
4991a3b 
Signed-off-by: Marija Najdova <mnajdova@gmail.com>
@mnajdova
Update NestedModal.js
60796e0 
Signed-off-by: Marija Najdova <mnajdova@gmail.com>
@mnajdova mnajdova merged commit c6b330b into mui:master Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli left review comments

@mnajdova mnajdova mnajdova approved these changes

@michaldudak michaldudak Awaiting requested review from michaldudak

Assignees
No one assigned
Labels
component: modal This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gitstart @mui-bot @mnajdova @ZeeshanTamboli @zannager