-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][base & joy] Display "Classes" Section in API docs #36589
Conversation
Netlify deploy previewhttps://deploy-preview-36589--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Benny, few comments.
- Should we name the section State classes? All other classes are included in the slots section
- Wait for the descriptions to be added before merging this
- Make the table same width as the other tables on the page
We will have conflicts with the tabs API PR, this is why I proposed to wait for that one to be merged first, but hopefully we can resolve the merge conflicts successfully.
Would be great if you can add tests for the changes introduced
Agree. Done.
Sure👌
Done.
Got it👌
Can you elaborate please? Tests for the function |
}, | ||
"name": "MuiSlider" | ||
}, | ||
"styles": { "classes": [], "globalClasses": {}, "name": "MuiSlider" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Joy Slider apparently had a "CSS" Section while all other Joy components didn't. Now we rather have a "State classes" section.
The concept is interesting 👍. The only information that I can think of that is missing is which slot is the class name available on, but it's likely overkill to solve this problem. |
d1020a8
to
24532cb
Compare
|
2a27054
to
9ee41e7
Compare
fc12564
to
4e9dd95
Compare
Doesn't the "Slots' table already achieve this? The slots with non-empty value cell in "Default class" column have matching class names while those with empty cell do not. Or I may have misunderstood your point. |
@siriwatknp @oliviertassinari Review reminder |
4e9dd95
to
239d191
Compare
239d191
to
5df0140
Compare
Been waiting for review quite a while 🥲 Rebased on master and applied the changes to |
@hbjORbj Push some fixes:
|
Thanks. I think this is ready for merge. |
9d6a598
to
e2bbc19
Compare
This is looking great! I was just randomly clicking through different components and I noticed that there's no info for the Joy UI Card component. Is there a reason why this one was skipped? If not, we should comb through these one more time to make sure all pages are included. |
@samuelsycamore Thanks for the review. This currently excludes components that only have |
Ah ok thanks for clarifying @hbjORbj ! In that case I think this is good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks for working on this!
We are missing the CSS classes title int he table of content in: https://deploy-preview-36589--material-ui.netlify.app/base/react-switch/components-api/ |
@mnajdova Thanks for the catch. Fixed it. |
I have followed (at least) the PR section of the contributing guide.
During the Friday backlog grooming session, I brought up this topic (displaying classnames for Joy/Base in API docs), and Marija/Michal/I agreed on creating a new section where we list the classnames except those already displayed in "Default class" column under "Slots" section. This is very open to suggestion for improvement.
This is also a follow-up of [Joy] Support
slots
/slotsProps
for every component (components with only root slot too) #36540 (review) pointed out by OlivierBefore:
After: