Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][base] Move styles code to bottom in the Button demos #36590

Merged
merged 2 commits into from
Mar 31, 2023
Merged

[docs][base] Move styles code to bottom in the Button demos #36590

merged 2 commits into from
Mar 31, 2023

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Mar 20, 2023

part of #36498

@mui-bot
Copy link

mui-bot commented Mar 20, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-36590--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 88183b5

@zannager zannager added component: button This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base labels Mar 21, 2023
@mnajdova mnajdova changed the title [Button][Base] Move styles code to bottom [docs][base] Move styles code to bottom in the Button demos Mar 21, 2023
@mnajdova mnajdova added the docs Improvements or additions to the documentation label Mar 21, 2023
mnajdova
mnajdova approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ZeeshanTamboli ZeeshanTamboli mentioned this pull request Mar 31, 2023
Closed
13 tasks
@ZeeshanTamboli ZeeshanTamboli changed the title [docs][base] Move styles code to bottom in the Button demos [docs][base] Move styles code to bottom in the Button demos Mar 31, 2023
@ZeeshanTamboli ZeeshanTamboli merged commit acd1463 into mui:master Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

@michaldudak michaldudak Awaiting requested review from michaldudak

Assignees
No one assigned
Labels
component: button This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sai6855 @mui-bot @mnajdova @ZeeshanTamboli @zannager