Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Use theme.applyDarkStyles #36606

Merged
merged 3 commits into from
Mar 23, 2023

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Mar 22, 2023

From #36602,

6d28f05 fixes the issue reported in slack

Screen.Recording.2566-03-22.at.13.25.10.mov

@siriwatknp siriwatknp added the docs Improvements or additions to the documentation label Mar 22, 2023
@mui-bot
Copy link

mui-bot commented Mar 22, 2023

Netlify deploy preview

https://deploy-preview-36606--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against f583f72

color: (theme.vars || theme).palette.primaryDark[300],
styles={(theme) => [
{
[theme.vars ? '[data-mui-color-scheme="dark"]:root' : '.mode-dark']: {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theme.applyDarkStyles only works with elements inside the body.

@siriwatknp siriwatknp marked this pull request as ready for review March 22, 2023 06:27
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 22, 2023
@mnajdova mnajdova changed the title [docs] use theme.applyDarkStyles [docs] Use theme.applyDarkStyles Mar 22, 2023
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I couldn't spot any regression

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 23, 2023
@siriwatknp siriwatknp merged commit d40cbdc into mui:master Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants