Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Make the Core page refer to group of products #37608

Merged
merged 15 commits into from
Jul 17, 2023

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Jun 16, 2023

This is yet another PR linked to the Base UI stable launch and it is a complementary one to #37583. Given we'll be getting the content that's currently on the Core page and making it "officially" about Material UI, the Core page needs to become something else (we don't want to lose the route and traffic we've accumulated on it up to this point, too). That said, for the time being, I'm doing something super simple right now but if it's worth it, we can make something more refined in the future.

https://deploy-preview-37608--material-ui.netlify.app/core

@danilo-leal danilo-leal added the website Pages that are not documentation-related, marketing-focused. label Jun 16, 2023
@danilo-leal danilo-leal added this to the Base UI: Stable release milestone Jun 16, 2023
@mui-bot
Copy link

mui-bot commented Jun 16, 2023

Netlify deploy preview

https://deploy-preview-37608--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 995bb32

@siriwatknp
Copy link
Member

@danilo-leal I wonder if each product should be bigger like the image below

image

@danilo-leal
Copy link
Contributor Author

@siriwatknp I'll explore more layout options, appreciate the suggestion! 🤙

@danilo-leal danilo-leal self-assigned this Jun 23, 2023
docs/src/components/productCore/CoreHero2.tsx Outdated Show resolved Hide resolved
docs/src/components/productCore/CoreHeroEnd.tsx Outdated Show resolved Hide resolved
docs/src/components/productCore/CoreProducts.tsx Outdated Show resolved Hide resolved
docs/src/components/productCore/CoreProducts.tsx Outdated Show resolved Hide resolved
docs/src/components/productCore/CoreProducts.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 3, 2023
@danilo-leal danilo-leal marked this pull request as ready for review July 3, 2023 09:41
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 3, 2023
@danilo-leal
Copy link
Contributor Author

danilo-leal commented Jul 3, 2023

@mnajdova @michaldudak Could y'all review this?

Given #37583 was merged a bit soon (my bad, should've stated that I was meaning to merge these two together) 😅, we might want to merge this too! The reason is: that PR pulled content from the previous Core page into a new Material UI one, so, by clicking on the "MUI Core" menu item on the "Product menu", visitors would be redirected to the Material UI page, which is not ideal. Having this PR up solves this (i.e. by clicking on MUI Core, visitors will land on the /core page that has a grid displaying all products part of it).

PS: I've left some commented code (with a note) on the CoreProducts file as it will all be put back in when logos for each of the products are ready to go.

@danilo-leal danilo-leal requested a review from mnajdova July 5, 2023 12:05
@mnajdova
Copy link
Member

Should we have some illustrations here?
image

The copy writing looks good to me 👍

@danilo-leal
Copy link
Contributor Author

@mnajdova they will come in later once the logos are finished! Let me know if it's good to go for now (need an approval) 😬

@danilo-leal danilo-leal merged commit 0fcf1e5 into master Jul 17, 2023
@danilo-leal danilo-leal deleted the simplify-core-page branch July 17, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Pages that are not documentation-related, marketing-focused.
Projects
Status: Recently completed
Development

Successfully merging this pull request may close these issues.

6 participants