-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] Make the Core page refer to group of products #37608
Conversation
Netlify deploy previewhttps://deploy-preview-37608--material-ui.netlify.app/ Bundle size report |
@danilo-leal I wonder if each product should be bigger like the image below |
@siriwatknp I'll explore more layout options, appreciate the suggestion! 🤙 |
@mnajdova @michaldudak Could y'all review this? Given #37583 was merged a bit soon (my bad, should've stated that I was meaning to merge these two together) 😅, we might want to merge this too! The reason is: that PR pulled content from the previous Core page into a new Material UI one, so, by clicking on the "MUI Core" menu item on the "Product menu", visitors would be redirected to the Material UI page, which is not ideal. Having this PR up solves this (i.e. by clicking on MUI Core, visitors will land on the /core page that has a grid displaying all products part of it). PS: I've left some commented code (with a note) on the |
@mnajdova they will come in later once the logos are finished! Let me know if it's good to go for now (need an approval) 😬 |
This is yet another PR linked to the Base UI stable launch and it is a complementary one to #37583. Given we'll be getting the content that's currently on the Core page and making it "officially" about Material UI, the Core page needs to become something else (we don't want to lose the route and traffic we've accumulated on it up to this point, too). That said, for the time being, I'm doing something super simple right now but if it's worth it, we can make something more refined in the future.
https://deploy-preview-37608--material-ui.netlify.app/core