[joy][Select] Set focus visible on select options when navigating with arrow keys #36689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: raj360 <34602861+raj360@users.noreply.github.com>
Netlify deploy previewhttps://deploy-preview-36689--material-ui.netlify.app/ Bundle size report |
|
@ZeeshanTamboli this PR is ready for review |
zannager
added
component: select
I'll let @siriwatknp review this PR. |
ZeeshanTamboli
changed the title
|
What's the verdict on this? @siriwatknp |
siriwatknp
requested changes
Apr 21, 2023
There was a problem hiding this comment.
The usage of the token should not change. Let's change the token value instead:
diff --git a/packages/mui-joy/src/styles/extendTheme.ts b/packages/mui-joy/src/styles/extendTheme.ts
index 5a2513dcc3..cc8d6f3738 100644
--- a/packages/mui-joy/src/styles/extendTheme.ts
+++ b/packages/mui-joy/src/styles/extendTheme.ts
@@ -356,7 +356,7 @@ export default function extendTheme(themeOptions?: CssVarsThemeOptions): Theme {
background: {
body: getCssVarColor('palette-neutral-900'),
surface: getCssVarColor('palette-common-black'),
- popup: getCssVarColor('palette-neutral-800'),
+ popup: getCssVarColor('palette-neutral-900'),
level1: getCssVarColor('palette-neutral-800'),
level2: getCssVarColor('palette-neutral-700'),
level3: getCssVarColor('palette-neutral-600'),
Co-authored-by: raj360 <34602861+raj360@users.noreply.github.com>
@siriwatknp thanks for the feedback, your comment has been addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sets focus visible on
<Li>when navigating with arrowkeys. @mui/joyuiCloses #36601
select-background.mov
This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.