Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Sync <Stack> between projects #36785

Merged
merged 2 commits into from
Apr 14, 2023
Merged

[docs] Sync <Stack> between projects #36785

merged 2 commits into from
Apr 14, 2023

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Apr 5, 2023 •
edited
Loading

I went into a rabbit hole from https://twitter.com/olivtassinari/status/1643701742821949443.

The issues:

  1. the Stack docs is inconsistent between Joy UI, Material UI, System. I almost feel like having System for the detailed content would be enough. When we improve the markdown, please let's fix all the pages.
  2. on Joy UI, fix the mission Stack in the live preview: https://mui.com/joy-ui/react-stack/

Screenshot 2023-04-05 at 23 47 05

  1. on System, remove all dependencies on Material UI https://mui.com/system/react-stack/

Screenshot 2023-04-05 at 23 47 42

  1. Improve the dark mode for Joy UI https://mui.com/joy-ui/react-stack/#flexbox-gap

Screenshot 2023-04-05 at 23 48 42

  1. Fix 404, we link the API page for the Stack in the IntelliSense but it's broken: https://mui.com/joy-ui/api/stack/

Screenshot 2023-04-05 at 23 50 46

  1. Fix 301, https://mui.com/joy-ui/react-stack redirects

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: Stack The React component. labels Apr 5, 2023
@mui-bot
Copy link

mui-bot commented Apr 5, 2023 •
edited
Loading

Netlify deploy preview

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against e913291

@oliviertassinari oliviertassinari changed the title [docs] Sync Stack between projects [docs] Sync <Stack> between projects Apr 7, 2023
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Apr 14, 2023
@oliviertassinari oliviertassinari merged commit 0046053 into mui:master Apr 14, 2023
@oliviertassinari oliviertassinari deleted the clearer-useFlexGap branch April 14, 2023 11:10
@oliviertassinari oliviertassinari mentioned this pull request Apr 23, 2023
Merged
oliviertassinari added a commit that referenced this pull request May 2, 2023
@oliviertassinari
[Stack] Fix import description
deb6b03 
Fix a regression from #36785.

Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
oliviertassinari
oliviertassinari commented May 2, 2023
View reviewed changes
docs/data/material/components/stack/stack.md

`Stack` is concerned with one-dimensional layouts, while [Grid](/material-ui/react-grid/) handles two-dimensional layouts. The default direction is `column` which stacks children vertically.
```jsx
import Stack from '@mui/joy/Stack';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in deb6b03

binh1298 pushed a commit to binh1298/material-ui that referenced this pull request May 17, 2023
@oliviertassinari @binh1298
[Stack] Fix import description
92e9fc0 
Fix a regression from mui#36785.

Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp Awaiting requested review from siriwatknp

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: Stack The React component. docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliviertassinari @mui-bot