[Option][base] Drop component prop #37052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
Netlify deploy previewhttps://deploy-preview-37052--material-ui.netlify.app/ Bundle size report |
michaldudak
reviewed
Apr 28, 2023
| > = OverrideProps<OptionTypeMap<OptionValue, {}, RootComponentType>, RootComponentType> & { | ||
| component?: RootComponentType; | ||
| }; | ||
| > = PolymorphicProps<OptionTypeMap<OptionValue, {}, RootComponentType>, RootComponentType>; | ||
|
|
||
| export interface OptionType { |
There was a problem hiding this comment.
OptionType should look similar to PolymorphicComponent (but with an additional generic OptionValue parameter):
export type OptionType = {
<OptionValue, RootComponentType extends React.ElementType>(
props: PolymorphicProps<OptionTypeMap<OptionValue>, RootComponentType>,
): JSX.Element | null;
propTypes?: any;
displayName?: string | undefined;
};
hbjORbj
force-pushed
the
option/componentProp
branch
from
d8484ac
to
16deb0f
Compare
michaldudak
reviewed
Apr 28, 2023
michaldudak
approved these changes
Apr 29, 2023
binh1298
pushed a commit
to binh1298/material-ui
that referenced
this pull request
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.