Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AutocompleteOption][Avatar][joy] js test replaced with ts test #37088

Merged
merged 2 commits into from
May 15, 2023
Merged

[AutocompleteOption][Avatar][joy] js test replaced with ts test #37088

merged 2 commits into from
May 15, 2023

Conversation

PunitSoniME
Copy link
Contributor

@PunitSoniME PunitSoniME commented Apr 29, 2023 •
edited
Loading

Part of #37078

@PunitSoniME PunitSoniME mentioned this pull request Apr 29, 2023
Closed
62 tasks
@mui-bot
Copy link

mui-bot commented Apr 29, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-37088--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against c9aa917

@zannager zannager added component: avatar This is the name of the generic UI component, not the React module! component: autocomplete This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels May 1, 2023
@zannager zannager requested a review from hbjORbj May 1, 2023 11:42
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels May 9, 2023
@PunitSoniME
[AutocompleteOption][Avatar][joy] js test replaced with ts test
ab31c29 
lint fail fixed

yarn docs:api command executed

suggested changed done

colorDefault removed from avatar model and test case

yarn doc api executed
hbjORbj
hbjORbj approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@hbjORbj hbjORbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@hbjORbj hbjORbj merged commit bcaab15 into mui:master May 15, 2023
binh1298 pushed a commit to binh1298/material-ui that referenced this pull request May 17, 2023
@PunitSoniME @binh1298
[AutocompleteOption][Avatar][joy] js test replaced with ts test (mui#…
8c22f48 
…37088)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbjORbj hbjORbj hbjORbj approved these changes

Assignees
No one assigned
Labels
component: autocomplete This is the name of the generic UI component, not the React module! component: avatar This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PunitSoniME @mui-bot @hbjORbj @zannager