[Typography][joy] Convert Typography test to TypeScript #37165
Conversation
Netlify deploy previewhttps://deploy-preview-37165--material-ui.netlify.app/ Bundle size report |
zannager
added
component: Typography
| import { expect } from 'chai'; | ||
| import * as React from 'react'; |
There was a problem hiding this comment.
Let's put this at the top of the file as it was
| import { createRenderer, describeConformance, describeJoyColorInversion } from 'test/utils'; | ||
| import Typography, { typographyClasses as classes } from '@mui/joy/Typography'; | ||
| import { ThemeProvider } from '@mui/joy/styles'; |
There was a problem hiding this comment.
Let's not change the order of imports
There was a problem hiding this comment.
Sorry, forgot to disable the import sorter..
| @@ -40,11 +40,13 @@ describe('<Typography />', () => { | |||
|
|
|||
| ['h1', 'h2', 'h3', 'h4', 'h5', 'h6', 'body1', 'body2', 'body3'].forEach((level) => { | |||
There was a problem hiding this comment.
| ['h1', 'h2', 'h3', 'h4', 'h5', 'h6', 'body1', 'body2', 'body3'].forEach((level) => { | |
| (['h1', 'h2', 'h3', 'h4', 'h5', 'h6', 'body1', 'body2', 'body3'] as const).forEach((level) => { |
| const classToCheck: string | RegExp = classes[level as keyof typeof classes]; | ||
| expect(container.firstChild).to.have.class(classToCheck); |
There was a problem hiding this comment.
Please revert the change. No error should be thrown if you address my comment above.
| expect((container.firstChild?.firstChild as HTMLElement)?.tagName).to.equal('SPAN'); | ||
| expect((container.firstChild?.lastChild as HTMLElement)?.tagName).to.equal('B'); |
There was a problem hiding this comment.
| expect((container.firstChild?.firstChild as HTMLElement)?.tagName).to.equal('SPAN'); | |
| expect((container.firstChild?.lastChild as HTMLElement)?.tagName).to.equal('B'); | |
| const child = container.firstChild?.firstChild ?? null; | |
| if (child === null) { | |
| return; | |
| } | |
| expect((child as HTMLElement).tagName).to.equal('SPAN'); | |
| expect((child as HTMLElement).tagName).to.equal('B'); |
There was a problem hiding this comment.
I'm not sure if this change would be appropiate:
The first expect checks for the firstChild while the second checks for the lastChild. I'll be changing this so that I put the container.firstChild in a value and check against null
There was a problem hiding this comment.
Oh, I missed that. Yes I exactly meant what you've done :) Thanks for addressing the comment.
hbjORbj
changed the title
This PR will change the test for the
Typographycomponent to TypeScript with associated changes. The test is still running without issues.See #37078