Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix Material Design templates #37187

Merged
merged 3 commits into from
May 13, 2023
Merged

[docs] Fix Material Design templates #37187

merged 3 commits into from
May 13, 2023

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented May 6, 2023 •
edited
Loading

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation design: material This is about Material Design, please involve a visual or UX designer in the process package: material-ui Specific to @mui/material design This is about UI or UX design, please involve a designer bug 馃悰 Something doesn't work regression A bug, but worse labels May 6, 2023
@oliviertassinari oliviertassinari mentioned this pull request May 6, 2023
Merged
@mui-bot
Copy link

mui-bot commented May 6, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-37187--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 馃毇 dangerJS against 0cc7bfb

mnajdova
mnajdova reviewed May 11, 2023
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pricing template that accidently used wrong theme looked much better "broken" 馃槃

docs/data/material/getting-started/templates/blog/MainFeaturedPost.js Outdated Show resolved Hide resolved
docs/data/material/getting-started/templates/blog/MainFeaturedPost.tsx Outdated Show resolved Hide resolved
@oliviertassinari
Copy link
Member Author

The pricing template that accidently used wrong theme looked much better "broken" 馃槃

@mnajdova It's not too hard to look better 馃榿, but we want this to be WYSIWYG.

@oliviertassinari oliviertassinari merged commit 512d5c7 into mui:master May 13, 2023
5 checks passed
@oliviertassinari oliviertassinari deleted the material-template-fix branch May 13, 2023 16:43
This was referenced May 16, 2023
Closed
Closed
Closed
binh1298 pushed a commit to binh1298/material-ui that referenced this pull request May 17, 2023
@oliviertassinari @binh1298
[docs] Fix Material Design templates (mui#37187)
faa8b6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova left review comments

Assignees
No one assigned
Labels
bug 馃悰 Something doesn't work design: material This is about Material Design, please involve a visual or UX designer in the process design This is about UI or UX design, please involve a designer docs Improvements or additions to the documentation package: material-ui Specific to @mui/material regression A bug, but worse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oliviertassinari @mui-bot @mnajdova