[Dialog] fixed broken dialog when using maxWidth="xs" and custom breakpoint unit #37237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-37237--material-ui.netlify.app/ Bundle size report |
|
@jguddas Thanks for working on this ~ Please provide a before/after reproduction so we can verify if it's indeed a bug and then test it. Also, for the future, it's better to open an issue describing the problem first 🙂 PS: You can use this template for a reproduction: https://mui.com/r/issue-template-latest |
|
Related to 9d91568 |
mj12albert
added
the
component: dialog
mj12albert
changed the title
|
Wow, that's true speed. |
ZeeshanTamboli
added
bug 🐛
binh1298
pushed a commit
to binh1298/material-ui
that referenced
this pull request
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #37241
Here's a demo of the fix: https://codesandbox.io/s/https-github-com-mui-material-ui-issues-37241-r5334g