[Stack] Fix CSS selector #37525
Merged
[Stack] Fix CSS selector #37525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-37525--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
sai6855
commented
Jun 6, 2023
sai6855
commented
Jun 23, 2023
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
oliviertassinari
approved these changes
Jul 1, 2023
| '& > :not(style) ~ :not(style)': { | ||
| // The useFlexGap={false} implement relies on each child to give up control of the margin. | ||
| // We need to reset the margin to avoid double spacing. | ||
| '& > :not(style):not(style)': { | ||
| margin: 0, |
There was a problem hiding this comment.
We could consider the path to not reset the margin in the first place. It would get closer to useFlexGap={true}'s behavior. I have made this proposal in #28035 (comment).
Suggested change
| margin: 0, |
The problem is that it's a bit more breaking change than the current changes in this PR, so maybe for v6.
Comment on lines
+138
to
+139
| // The useFlexGap={false} implement relies on each child to give up control of the margin. | ||
| // We need to reset the margin to avoid double spacing. |
There was a problem hiding this comment.
Suggested change
| // The useFlexGap={false} implement relies on each child to give up control of the margin. | |
| // We need to reset the margin to avoid double spacing. | |
| // The useFlexGap={false} implementation relies on each child to give up control of the margin. | |
| // We need to reset the margin to avoid double spacing. | |
| // TODO: remove this reset https://github.com/mui/material-ui/issues/28035#issuecomment-1615855826 |
|
@DiegoAndai Do you want to own the merge of this PR? I see you are a maintainer of the Stack component with Jun https://www.notion.so/mui-org/Components-Layout-72421c160bcd4089a8ef8a4fd804c950. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #37381 by forcing the
margin: 0reset on all the children of the Stack component. Before this change, the reset is done on almost all the children but not the first child.https://deploy-preview-37525--material-ui.netlify.app/system/react-stack/
before: https://codesandbox.io/s/sad-aj-45wiii?file=/src/App.js
after: https://codesandbox.io/s/sharp-sun-7pgg8k?file=/package.json