[core] Remove the deprecation rule in tslint #38087
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TSLint's
deprecation
rule is broken, spamming the console with errors likemessage.trim() is not a function
. Indeed the rule's code makes wrong assumptions about what gets returned from the parser.The fix is theoretically very simple, but since TSLint is no longer maintained, it is not an option.
I tried to replace it with https://github.com/gund/eslint-plugin-deprecation, but it's insanely slow, so it's a no-go.