Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Remove the deprecation rule in tslint #38087

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

michaldudak
Copy link
Member

The TSLint's deprecation rule is broken, spamming the console with errors like message.trim() is not a function. Indeed the rule's code makes wrong assumptions about what gets returned from the parser.
The fix is theoretically very simple, but since TSLint is no longer maintained, it is not an option.

I tried to replace it with https://github.com/gund/eslint-plugin-deprecation, but it's insanely slow, so it's a no-go.

@michaldudak michaldudak added the core Infrastructure work going on behind the scenes label Jul 21, 2023
@michaldudak michaldudak requested a review from a team July 21, 2023 09:30
@mui-bot
Copy link

mui-bot commented Jul 21, 2023

Netlify deploy preview

https://deploy-preview-38087--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against fe4b374

@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 21, 2023

MUI X moved away from TSLint: https://github.com/mui/mui-x/blob/e3932b3fc9a3b51bb6fe147c5c894be86254e531/packages/grid/x-data-grid/package.json#L33, I imagine they gave up on this deprecated feature: https://palantir.github.io/tslint/rules/deprecation/.

If we give up on it too here, then nothing would stop us to move away from TSLint?

I have upvoted: microsoft/TypeScript#49433.

@michaldudak
Copy link
Member Author

Our TSLint checks rules defined in https://github.com/microsoft/dtslint/blob/master/dtslint.json.
We'd have to check if equivalent rules exist in ESLint before getting rid of TSLint altogether.

@michaldudak michaldudak merged commit 0c62711 into mui:master Jul 24, 2023
@michaldudak michaldudak deleted the tslint-disable-deprecation branch July 24, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants