[docs-infra] Move imports into page data #38297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-38297--material-ui.netlify.app/ Bundle size report |
This was referenced Aug 3, 2023
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
michaldudak
reviewed
Aug 3, 2023
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
alexfauquette
commented
Aug 3, 2023
Comment on lines
+45
to
+48
| "imports": [ | ||
| "import { Unstable_NumberInput as NumberInput } from '@mui/base/Unstable_NumberInput';", | ||
| "import { Unstable_NumberInput as NumberInput } from '@mui/base';" | ||
| ], |
There was a problem hiding this comment.
michaldudak
reviewed
Aug 8, 2023
| return ( | ||
| <React.Fragment key={`component-api-${key}`}> | ||
| <MarkdownElement> | ||
| <Heading hash={componentNameKebabCase} text={`${componentName} API`} /> | ||
| <Heading text="import" hash={`${componentNameKebabCase}-import`} level="h3" /> | ||
| <HighlightedCode code={importInstructions} language="jsx" /> | ||
| <HighlightedCode | ||
| code={imports.join(` |
There was a problem hiding this comment.
Nit: could you extract this to a variable? Having multiline template string within JSX looks a bit off to me (same in HooksApiContent).
| @@ -109,30 +110,6 @@ export default function ComponentsApiContent(props) { | |||
| slotGuideLink = '/base-ui/guides/overriding-component-structure/'; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I like how it's much cleaner now :)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reuse the
ApiPagecomponent from the monorepo, X needs to be able provide its own import data. So I move the import snipets from the API page components to thedocs:apiscriptComming from this comment
After/Before (screenshot order)
material
joy
base
components
hook
System
The right side is from the production website. The preview does not have it so it's a bug fix ;)
I don't know why I(s the only component with this behavior