Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][base-ui] Fix Menu Hooks demo #38479

Merged
merged 1 commit into from
Aug 17, 2023
Merged

[docs][base-ui] Fix Menu Hooks demo #38479

merged 1 commit into from
Aug 17, 2023

Conversation

homerchen19
Copy link
Contributor

Fixed #38389

@mui-bot
Copy link

mui-bot commented Aug 15, 2023 •
edited

Netlify deploy preview

https://deploy-preview-38479--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 3c77e74

@homerchen19 homerchen19 marked this pull request as ready for review August 15, 2023 05:06
@zannager zannager added docs Improvements or additions to the documentation package: base-ui Specific to @mui/base labels Aug 15, 2023
michaldudak
michaldudak approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks a lot for your contribution!

@michaldudak michaldudak added the component: menu This is the name of the generic UI component, not the React module! label Aug 17, 2023
@michaldudak michaldudak merged commit 8f2f732 into mui:master Aug 17, 2023
21 checks passed
@homerchen19 homerchen19 deleted the fix/fix-use-menu-demo branch August 18, 2023 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak approved these changes

Assignees
No one assigned
Labels
component: menu This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs][base][Menu] Keyboard navigation doesn't work in Hooks demo
4 participants
@homerchen19 @mui-bot @michaldudak @zannager