Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Autocomplete] Type multiple values with readonly arrays." #38827

Merged
merged 1 commit into from
Sep 9, 2023

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Sep 6, 2023

Reverts #38253, see #38817.

Next actions should be:

  • move the current useAutocomplete in Material UI
  • iterate on the useAutocomplete in Base UI - test the changes in Joy UI
  • in v6, migrate Material UI's Autocomplete to use the Base UI's useAutocomplete

@mnajdova mnajdova added component: autocomplete This is the name of the generic UI component, not the React module! regression A bug, but worse labels Sep 6, 2023
@mnajdova mnajdova marked this pull request as ready for review September 8, 2023 08:32
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mnajdova mnajdova merged commit c8568ae into master Sep 9, 2023
16 checks passed
@mnajdova mnajdova deleted the revert-38253-readonly-array-value branch September 9, 2023 12:10
anon-phantom pushed a commit to anon-phantom/material-ui that referenced this pull request Sep 11, 2023
@pcorpet
Copy link
Contributor

pcorpet commented Oct 15, 2023

@mnajdova anything I can do to help, or at least track the progress of getting #38253 or an equivalent in v6 please?

@mnajdova
Copy link
Member Author

@pcorpet sorry for the delay. We can start by opening an issue and linking the appropriate PRs to give visibility on what was done. We should follow the steps in the PR description.

@pcorpet
Copy link
Contributor

pcorpet commented Nov 2, 2023

OK, for reference here is the issue mui/base-ui#55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: autocomplete This is the name of the generic UI component, not the React module! regression A bug, but worse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants