Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Move types packages to docs' devDependencies #38914

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

michaldudak
Copy link
Member

@michaldudak michaldudak commented Sep 11, 2023

We had a duplicated @types dependency in docs (in both dependencies and devDependencies). This PR moves all types to devDependencies.

#38859 (comment)

@michaldudak michaldudak added core Infrastructure work going on behind the scenes website Pages that are not documentation-related, marketing-focused. labels Sep 11, 2023
@michaldudak michaldudak requested a review from a team September 11, 2023 07:44
@mui-bot
Copy link

mui-bot commented Sep 11, 2023

Netlify deploy preview

https://deploy-preview-38914--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against d1928ac

Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@michaldudak michaldudak merged commit fca407c into mui:master Sep 11, 2023
7 checks passed
@michaldudak michaldudak deleted the docs-devDependencies branch September 11, 2023 08:45
@oliviertassinari
Copy link
Member

👌

@oliviertassinari oliviertassinari removed the website Pages that are not documentation-related, marketing-focused. label Sep 11, 2023
anon-phantom pushed a commit to anon-phantom/material-ui that referenced this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants