-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Update link to add custom color in palette #39359
[docs] Update link to add custom color in palette #39359
Conversation
ZeeshanTamboli
commented
Oct 9, 2023
- I have followed (at least) the PR section of the contributing guide.
Netlify deploy previewhttps://deploy-preview-39359--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch!
Thanks for catching and fixing this. We have some checks for broken links; do you know if these cases are not covered? |
I am not aware that we have checks for broken links. |
I was thinking about |
Yes maybe we could. That would be great. @alexfauquette might have more insights. I see it was introduced in #34588. It seems we also utilize ahrefs to identify broken links. |
Yes I have :) ahrefs is a scroller that implies two limitations:
About
and we check if all internal links exist (the page and the hash) For now, API pages are ignored because we don't handle the hash added by the page rendering (for example https://mui.com/material-ui/api/alert/#import or now https://mui.com/material-ui/api/alert/#Alert-prop-children) so it would put to many false positive. For your usecase, you should modify the |