[base-ui] Textarea POC #41005
Closed
[base-ui] Textarea POC #41005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj12albert
added
package: base-ui
Netlify deploy previewBundle size reportBundle size will be reported once CircleCI build #650196 finishes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there any point to composing this with a root
divand a subcomponent instead of just<Textarea>? If we don't need adornments, the only other difference it makes is we may not need to use a Fragment to contain the hidden textareaI re-used the
Textbox(root) from [base-ui] POC: Input using component-per-node pattern #40893 to speed this up, but I wonder if we should reuse it more (e.g. for theNumberInputroot)Is there a point to extracting a hook out of
TextareaAutosize?Some features - e.g. the
focusedstate - was previously provided byuseInput, it'll need to be reimplemented hereI have followed (at least) the PR section of the contributing guide.