[codemod] Add utils for *Component and *Props props deprecations
#41685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiegoAndai
commented
Mar 27, 2024
Comment on lines
-14
to
-16
| }} | ||
| slotProps={{ | ||
| root: { className: 'foo' }, |
There was a problem hiding this comment.
slotProps is not modified in the backdrop-props codemod, so there's no need for it on the test case. Same for line 22.
DiegoAndai
commented
Mar 27, 2024
| @@ -8,17 +8,18 @@ import { Backdrop as MyBackdrop } from '@mui/material'; | |||
| slots={{ | |||
| root: 'div', | |||
| }} | |||
| slotProps={{ | |||
There was a problem hiding this comment.
slotProps is not modified in the backdrop-props codemod, so there's no need for it on the test case. Same for line 20.
Netlify deploy previewhttps://deploy-preview-41685--material-ui.netlify.app/ Bundle size report |
mnajdova
approved these changes
Apr 10, 2024
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #41281
Add
movePropIntoSlotsandmovePropIntoSlotPropsutils for creating codemods, simplifying the development of new codemods for the*Componentand*Propsprops deprecations.Use these new utils on the existing
*Componentand*Propsprops deprecations and add tests for edge cases.