-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[code-infra] Make Babel config path configurable in API docs builder #41999
Conversation
Netlify deploy previewhttps://deploy-preview-41999--material-ui.netlify.app/ Bundle size report |
I think it should be possible to leverage // config property should contain the path to the project babel.config.js file that applies to `pathToCodeFile`
const { config } = babelCore.loadPartialConfig({ fileName: pathToCodeFile }) |
Thanks! I didn't realize Babel would look for the config automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for checking. Approving under the assumption the babelConfigPath
setting will be removed.
The Babel configuration path in the API docs builder was hardcoded, causing problems when the package was used in other repositories.
Added the relevant configuration field (defaulting to the previous value).