Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][Chip] Add colorDefault class to chipClasses #42067

Merged
merged 2 commits into from
May 2, 2024
Merged

[material-ui][Chip] Add colorDefault class to chipClasses #42067

merged 2 commits into from
May 2, 2024

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Apr 30, 2024

if color prop is not provided or if color is set to default, .MuiChip-colorDefault class is added to Chip's root. but this class is not accessiable from chipClasses. This PR adds colorDefault to chipClasses interface

@sai6855 sai6855 marked this pull request as draft April 30, 2024 13:12
@sai6855 sai6855 changed the title [material-ui][Chip] [material-ui][Chip] Add colorDefault class to chipClasses Apr 30, 2024
@sai6855 sai6855 added docs Improvements or additions to the documentation component: chip This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Apr 30, 2024
@mui-bot
Copy link

mui-bot commented Apr 30, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-42067--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against ef735b0

@sai6855 sai6855 marked this pull request as ready for review April 30, 2024 13:33
@sai6855 sai6855 requested a review from DiegoAndai April 30, 2024 13:33
DiegoAndai
DiegoAndai approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sai6855 🙌🏼

@DiegoAndai DiegoAndai merged commit 7bc7de6 into mui:next May 2, 2024
22 checks passed
@sai6855 sai6855 deleted the chip-default-class branch May 2, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoAndai DiegoAndai DiegoAndai approved these changes

Assignees
No one assigned
Labels
component: chip This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sai6855 @mui-bot @DiegoAndai