[material-ui][TableSortLabel] Deprecate composed classes #42281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai6855
added
component: table
Netlify deploy previewBundle size reportDetails of bundle changes (Toolpad) |
sai6855
commented
May 17, 2024
| @@ -26,6 +34,8 @@ const tableSortLabelClasses: TableSortLabelClasses = generateUtilityClasses('Mui | |||
| 'icon', | |||
| 'iconDirectionDesc', | |||
| 'iconDirectionAsc', | |||
| 'directionDesc', | |||
| }); | ||
|
|
||
| it('when given direction asc should have asc direction class', () => { | ||
| const { container } = render(<TableSortLabel direction="asc" />); | ||
| const icon = container.querySelector(`.${classes.icon}`); | ||
| expect(icon).not.to.have.class(classes.iconDirectionDesc); | ||
| expect(icon).to.have.class(classes.iconDirectionAsc); | ||
| expect(container.firstChild).to.have.class(classes.directionAsc); | ||
| expect(container.querySelector(`.${classes.directionAsc} > .${classes.icon}`)).not.equal( |
There was a problem hiding this comment.
just to make sure replacement selector is actually working
sai6855
changed the title
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
|
Not sure about argos failure, don't think they are related to this PR |
DiegoAndai
reviewed
Jun 12, 2024
There was a problem hiding this comment.
Hey @sai6855, thanks for working on this, sorry for the delay in the review.
30 tasks
joserodolfofreitas
pushed a commit
to joserodolfofreitas/material-ui
that referenced
this pull request
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #41282