Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Add stray design polish #42646

Merged
merged 7 commits into from
Jun 19, 2024

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Jun 14, 2024

Just the usual housekeeping stuff. Commits are descriptive of the changes.
The biggest highlight here, design-wise, is the simplification of the sponsor's block on the table of contents.

@danilo-leal danilo-leal added design This is about UI or UX design, please involve a designer website Pages that are not documentation-related, marketing-focused. scope: docs-infra Specific to the docs-infra product labels Jun 14, 2024
@danilo-leal danilo-leal requested a review from zanivan June 14, 2024 20:11
@danilo-leal danilo-leal self-assigned this Jun 14, 2024
@mui-bot
Copy link

mui-bot commented Jun 14, 2024

Netlify deploy preview

https://deploy-preview-42646--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 5ce356a

Copy link
Contributor

@zanivan zanivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks great! Not gonna lie, I really liked the old style for the "Become a Sponsor" button. It felt like filling an empty space, like when you're pasting stickers in an album 😅

Screenshot 2024-06-18 at 10 00 04

packages/mui-docs/src/branding/brandingTheme.ts Outdated Show resolved Hide resolved
docs/src/modules/components/DiamondSponsors.js Outdated Show resolved Hide resolved
docs/src/modules/components/DiamondSponsors.js Outdated Show resolved Hide resolved
@danilo-leal
Copy link
Contributor Author

danilo-leal commented Jun 19, 2024

@zanivan what do you think about this? Iterated with your "sticker album" idea—I guess it kinda gets what I was trying to do with what you suggested together?

Screenshot 2024-06-19 at 14 15 44

Copy link
Contributor

@zanivan zanivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@danilo-leal danilo-leal merged commit da4546d into mui:next Jun 19, 2024
22 checks passed
@danilo-leal danilo-leal deleted the stray-design-polish branch June 19, 2024 18:35
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This is about UI or UX design, please involve a designer scope: docs-infra Specific to the docs-infra product website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants