Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Grid Layout-> AutoHeight causes rerender which makes text "no records found" removed after filtering #6970

Closed
2 tasks done
Mehakb opened this issue Nov 23, 2022 · 17 comments
Assignees
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module!

Comments

@Mehakb
Copy link

Mehakb commented Nov 23, 2022

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Steps to reproduce 🕹

Link to live example: https://codesandbox.io/s/dazzling-architecture-ojnqfh?file=/demo.tsx (v5)

https://codesandbox.io/s/beautiful-silence-24ue6i?file=/demo.tsx (v6)

Steps:

  1. Hover on desk column -> Click on three dots on the right of column-> Choose filter.
  2. Inside value type any random text so you get no records found.
  3. You will see blank space instead of text "No records found"

Current behavior 😯

Here is the demo for current behaviour
https://watch.screencastify.com/v/qE5FmDEQ7HsGQmvlf64K

Expected behavior 🤔

The No results found text should appear instead of blank space

Context 🔦

I need to display the text when filter do not find any records

Your environment 🌎

I am Using Chrome Browser

@Mehakb Mehakb added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Nov 23, 2022
@zannager zannager added the component: data grid This is the name of the generic UI component, not the React module! label Nov 23, 2022
@m4theushw m4theushw removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Nov 23, 2022
@m4theushw m4theushw self-assigned this Nov 23, 2022
@m4theushw m4theushw added the bug 🐛 Something doesn't work label Nov 23, 2022
@cherniavskii
Copy link
Member

Maybe I'm missing something, but I see the "No results found" overlay in both v5 and v6 demos linked in the issue description:
Screenshot 2022-12-01 at 21 44 00

@m4theushw
Copy link
Member

m4theushw commented Dec 1, 2022

@cherniavskii You have to try several times and even switch browser to reproduce the bug. I don't know if this works but seems that reducing the height, to show the scrollbar, makes the problem more preeminent.

@Mehakb
Copy link
Author

Mehakb commented Dec 2, 2022

@cherniavskii When we have pageSize as 2 then height of datagrid is not changing and thus you will not be able to reproduce the issue. You need to have pageSize which changes height of datagrid so the autoheight comes to work and then you can observe the issue. You can refer the demo attached in current behavior section of the issue

@cherniavskii
Copy link
Member

You have to try several times and even switch browser to reproduce the bug

Tried with different browsers and different window sizes, but no luck. Maybe it's not reproducible on MacOS?
I'll try to review the PR anyway.

@cherniavskii
Copy link
Member

When we have pageSize as 2 then height of datagrid is not changing and thus you will not be able to reproduce the issue

In the demos I've tried pageSize is set to 10.

You can refer the demo attached in current behavior section of the issue

In the current behavior section, there's only a video. I've tried demos from "Steps to reproduce" instead

@Mehakb
Copy link
Author

Mehakb commented Dec 6, 2022

@cherniavskii Kindly try to set pageSize of 100 and then see if you are able to reproduce it in the demo. Just FYI.. I am using Windows 11.

Here is the link: https://codesandbox.io/s/dazzling-architecture-ojnqfh?file=/demo.tsx

@Mehakb
Copy link
Author

Mehakb commented Jan 5, 2023

@cherniavskii any update on the PR?

@cherniavskii
Copy link
Member

Hey @Mehakb
Thanks, I can reproduce it now. I've noticed that the viewport height is making the difference, I had to experiment with different heights to reproduce it.
I'll review the PR fixing the issue.

@Mehakb
Copy link
Author

Mehakb commented Jan 12, 2023

@cherniavskii Good to know you are able to reproduce the issue. Thanks in advance for your efforts to review PR.

@Mehakb
Copy link
Author

Mehakb commented Feb 11, 2023

Hi @cherniavskii @m4theushw

Hope you both are doing well!

Any updates related to PR's?

@Mehakb
Copy link
Author

Mehakb commented Mar 30, 2023

Hi @cherniavskii @m4theushw

Any update on the PR?

@Mehakb
Copy link
Author

Mehakb commented Apr 3, 2023

Hi,

Any update on when we can expect this issue to be fixed?

@cherniavskii
Copy link
Member

@Mehakb Sorry, we lost track of this issue and the related PR. We will try to get back to it soon!

@boldurean
Copy link

boldurean commented May 19, 2023

Also waiting for this fix as Grids look weird with all no reason scrollbars

@cherniavskii
Copy link
Member

@Mehakb
I cannot reproduce it with the latest v6 version anymore: https://codesandbox.io/s/optimistic-montalcini-668x7x?file=/demo.tsx
Can you confirm it's resolved?

@cherniavskii
Copy link
Member

I believe it was fixed by #8091

@cherniavskii cherniavskii added the status: waiting for author Issue with insufficient information label May 19, 2023
@Mehakb
Copy link
Author

Mehakb commented May 19, 2023

@cherniavskii This issue is resolved for now. Thanks for fix.

@github-actions github-actions bot removed the status: waiting for author Issue with insufficient information label May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
5 participants