Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data grid] Use ResizeObserver to detect resize #7297

Closed
2 tasks done
m4theushw opened this issue Dec 21, 2022 · 0 comments · Fixed by #8091
Closed
2 tasks done

[data grid] Use ResizeObserver to detect resize #7297

m4theushw opened this issue Dec 21, 2022 · 0 comments · Fixed by #8091
Assignees
@m4theushw
Labels
component: data grid This is the name of the generic UI component, not the React module!

Comments

@m4theushw
Copy link
Member

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Summary 💡

According to https://mui.com/material-ui/getting-started/supported-platforms/#browser, ResizeObserver can already be used instead of the hack with <div className="Mui-resizeTriggers" />.

mui-x/packages/grid/x-data-grid/src/lib/createDetectElementResize/index.js

Lines 12 to 13 in fe389c3

* TODO replace with https://developer.mozilla.org/en-US/docs/Web/API/ResizeObserver
* once browser support allows it.

Examples 🌈

No response

Motivation 🔦

It will help with support for Shadow DOM, see #7286

Order ID 💳 (optional)

No response
@m4theushw m4theushw added the component: data grid This is the name of the generic UI component, not the React module! label Dec 21, 2022
@m4theushw m4theushw self-assigned this Feb 17, 2023
@m4theushw m4theushw mentioned this issue Mar 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m4theushw m4theushw

Labels
component: data grid This is the name of the generic UI component, not the React module!
Projects
MUI X Data Grid
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DataGrid] Replace GridAutoSizer with ResizeObserver m4theushw/mui-x
1 participant
@m4theushw