Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Fix onPageChange and onPageSizeChange event trigger #1034

Merged
merged 5 commits into from
Feb 12, 2021
Merged

[DataGrid] Fix onPageChange and onPageSizeChange event trigger #1034

merged 5 commits into from
Feb 12, 2021

Conversation

dtassone
Copy link
Member

@dtassone dtassone commented Feb 12, 2021 •
edited
Loading

Fix #885

  • onPageChange should only fire when the underlying state change, it doesn't change when the component mount.

Fix #848

@dtassone
Copy link
Member Author

dtassone commented Feb 12, 2021 •
edited
Loading

This fix does not include the following

  • onPageChange should have two arguments (event, page)

This is an issue across all events of the grid. We need to unify those events.

@dtassone dtassone self-assigned this Feb 12, 2021
@oliviertassinari oliviertassinari changed the title [DataGrid] fix onPageChange and onPageSizeChange event trigger [DataGrid] Fix onPageChange and onPageSizeChange event trigger Feb 12, 2021
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! labels Feb 12, 2021
@dtassone dtassone merged commit f471818 into mui:master Feb 12, 2021
@missbruni missbruni mentioned this pull request Sep 27, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@DanailH DanailH DanailH approved these changes

Assignees

@dtassone dtassone

Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
3 participants
@dtassone @oliviertassinari @DanailH