Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Rename global to globalScope due to Jest issue #10470

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

romgrk
Copy link
Contributor

@romgrk romgrk commented Sep 25, 2023

Fixes #10056 (comment)

Jest already has a variable named global in scope in their build process and it prevents code from reusing that name.

NOTE: AUTO-MERGE ENABLED

@romgrk romgrk added the component: data grid This is the name of the generic UI component, not the React module! label Sep 25, 2023
@romgrk romgrk enabled auto-merge (squash) September 25, 2023 19:19
@mui-bot
Copy link

mui-bot commented Sep 25, 2023

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-10470--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms -199.8 115.9 -199.8 -49.72 106.473
Sort 100k rows ms 754.1 1,492.1 1,395.9 1,226.38 257.032
Select 100k rows ms 699.7 933.7 782.7 803.96 89.622
Deselect 100k rows ms 161.7 366.3 195.5 220.3 74.269

Generated by 🚫 dangerJS against 86655af

Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romgrk romgrk merged commit 4f85b7f into mui:master Sep 25, 2023
6 checks passed
@romgrk romgrk deleted the fix-global-variable-name branch September 25, 2023 19:50
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work test labels Sep 25, 2023
@oliviertassinari
Copy link
Member

For context, we used a bit this in the past:

import { ponyfillGlobal } from '@mui/utils';

but likely not relevant here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataGrid] esbuild & terser no longer minifying, hide eval calls from bundlers
4 participants