Fix filter input value #10691
Closed
Fix filter input value #10691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jasmyneokudo <38866525+jasmyneokudo@users.noreply.github.com>
|
Deploy preview: https://deploy-preview-10691--material-ui-x.netlify.app/ |
zannager
added
the
component: data grid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[data grid]
onFilterModelChangefires with stale field valueSuggestion to fix Issue
Upon investigation, we discovered that this issue occurs when a user wants to filter a value in a String column and then tries to change the String Column to a Number column. When this happens, the program tries to parse the string value the user initially inputted in the Value Textfield to a number value, because it's unable to do that, it clears out the value from the Text Field but the value still remains in the items object in the program.
The simple solution to this would be to reset the
itemvalue property when the user switches from one column to another.This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.