-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pickers] Modify adapter.isValid
method to accept TDate | null
instead of any
#10971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
breaking change
component: pickers
This is the name of the generic UI component, not the React module!
labels
Nov 9, 2023
Deploy preview: https://deploy-preview-10971--material-ui-x.netlify.app/ Updated pages: |
flaviendelangle
changed the title
Is valid typing
[pickers] Modify Nov 9, 2023
adapter.isValid
method to accept TDate | null
instead of any
flaviendelangle
force-pushed
the
isValid-typing
branch
from
November 9, 2023 15:15
e4e55fd
to
0f4fd0d
Compare
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Nov 10, 2023
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
docs/data/migration/migration-pickers-v6/migration-pickers-v6.md
Outdated
Show resolved
Hide resolved
packages/x-date-pickers/src/AdapterMomentJalaali/AdapterMomentJalaali.ts
Show resolved
Hide resolved
alexfauquette
approved these changes
Nov 10, 2023
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Nov 10, 2023
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Nov 10, 2023
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
component: pickers
This is the name of the generic UI component, not the React module!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10970
Changelog
Breaking changes
The
adapter.isValid
method used to accept any type of value and tried to parse them before checking their validity.The method has been simplified and now only accepts an already-parsed date or
null
.Which is the same type as the one accepted by the components
value
prop.