[test] Wait for images to load #11004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-11004--material-ui-x.netlify.app/ |
cherniavskii
commented
Nov 11, 2023
| @@ -101,12 +101,6 @@ async function main() { | |||
| // Move cursor offscreen to not trigger unwanted hover effects. | |||
| page.mouse.move(0, 0); | |||
|
|
|||
| // Wait for the flags to load | |||
| await page.waitForFunction(() => { | |||
| const images = Array.from(document.querySelectorAll('img')); | |||
There was a problem hiding this comment.
This didn't work, because sometimes the images were not rendered yet - so I moved it after the '[data-testid="testcase"]:not([aria-busy="true"])' assertion
| () => { | ||
| const images = Array.from(document.querySelectorAll('img')); | ||
| return images.every((img) => { | ||
| if (!img.complete && img.loading === 'lazy') { |
There was a problem hiding this comment.
For lazy-loaded images that are not visible img.complete will always be false
| }); | ||
| }, | ||
| undefined, | ||
| { timeout: 1000 }, |
|
It worked! 🎉 
|
michelengelen
approved these changes
Nov 11, 2023
MBilalShafi
approved these changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes false-positives like https://app.argos-ci.com/mui/mui-x/builds/15042/64442787