[pickers] Clean remaining components / componentsProps typings
#11040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-11040--material-ui-x.netlify.app/ |
flaviendelangle
added
typescript
component: pickers
flaviendelangle
commented
Nov 15, 2023
| @@ -168,7 +168,9 @@ GridToolbarFilterButton.propTypes = { | |||
| * The props used for each slot inside. | |||
| * @default {} | |||
| */ | |||
| componentsProps: PropTypes.object, | |||
| componentsProps: PropTypes.shape({ | |||
There was a problem hiding this comment.
@MBilalShafi this component should probably not have this prop anymore
There was a problem hiding this comment.
Thanks for mentioning it, I'll make sure to address this along with a related breaking change
alexfauquette
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.