Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGridPremium] Fix aggregated column ignoring column definition changes #11129

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

cherniavskii
Copy link
Member

Fixes #10864

@cherniavskii cherniavskii added component: data grid This is the name of the generic UI component, not the React module! regression A bug, but worse plan: Premium Impact at least one Premium user feature: Editing Related to the data grid Editing feature feature: Aggregation Related to the data grid Aggregation feature labels Nov 21, 2023
@mui-bot
Copy link

mui-bot commented Nov 21, 2023

Deploy preview: https://deploy-preview-11129--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 5327329

@cherniavskii cherniavskii marked this pull request as ready for review November 21, 2023 14:50
@cherniavskii cherniavskii added the needs cherry-pick The PR should be cherry-picked to master after merge label Nov 24, 2023
@cherniavskii cherniavskii merged commit 07b2e18 into mui:next Nov 24, 2023
24 checks passed
@cherniavskii cherniavskii deleted the editable-aggegation branch November 24, 2023 21:27
cherniavskii added a commit to cherniavskii/mui-x that referenced this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! feature: Aggregation Related to the data grid Aggregation feature feature: Editing Related to the data grid Editing feature needs cherry-pick The PR should be cherry-picked to master after merge plan: Premium Impact at least one Premium user regression A bug, but worse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[data grid] Aggregated columns don't respond to changes in the "editable" property of the GridColDef
3 participants