Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGridPro] Add inputRef to the props passed to colDef.renderHeaderFilter #12328

Merged
merged 8 commits into from
Mar 12, 2024
Merged

[DataGridPro] Add inputRef to the props passed to colDef.renderHeaderFilter #12328

merged 8 commits into from
Mar 12, 2024

Conversation

layerok
Copy link
Contributor

@layerok layerok commented Mar 4, 2024 •
edited by MBilalShafi
Loading

Fixes #12326

@mui-bot
Copy link

mui-bot commented Mar 4, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-12328--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 5c15ef0

@MBilalShafi MBilalShafi changed the title fix loss of focus on input element when typing inside a custom header… [DataGrid] Include inputRef to the params passed to colDef.renderHeaderFilter Mar 5, 2024
@MBilalShafi MBilalShafi changed the title [DataGrid] Include inputRef to the params passed to colDef.renderHeaderFilter [DataGridPro] Include inputRef to the params passed to colDef.renderHeaderFilter Mar 5, 2024
@MBilalShafi MBilalShafi added component: data grid This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature feature: Filtering on header Related to the header filtering (Pro) feature MUI X Pro CLA: required See https://www.notion.so/mui-org/CLA-Contributor-License-Agreement-92ece655b1584b10b00e4de9e67eedb0 labels Mar 5, 2024
@MBilalShafi
Copy link
Member

@vovarudomanenko Thank you for this pull request! 🙇

Your changes seem to impact the commercially licensed code. For any changes of this nature, we require contributors to sign the MUI’s Contributor License Agreement (CLA).

However, I can’t find a CLA signed that could cover these changes. Please follow the steps at https://mui-org.notion.site/CLA-Contributor-License-Agreement-92ece655b1584b10b00e4de9e67eedb0 to sign the document.

@MBilalShafi MBilalShafi changed the title [DataGridPro] Include inputRef to the params passed to colDef.renderHeaderFilter [DataGridPro] Add inputRef to the props passed to colDef.renderHeaderFilter Mar 5, 2024
@layerok
Copy link
Contributor Author

layerok commented Mar 5, 2024

done

@zannager
Copy link
Member

zannager commented Mar 5, 2024

@vovarudomanenko, can you please complete the step 3 - Forward the “form submission confirmation” email (check also your spam folder) to team-legal@mui.com to confirm your identity. Also, include the link to the pull request it corresponds to. Thanks.

@layerok
Copy link
Contributor Author

layerok commented Mar 5, 2024

@zannager done

@zannager zannager added CLA: signed See https://www.notion.so/mui-org/CLA-Contributor-License-Agreement-92ece655b1584b10b00e4de9e67eedb0 and removed CLA: required See https://www.notion.so/mui-org/CLA-Contributor-License-Agreement-92ece655b1584b10b00e4de9e67eedb0 labels Mar 5, 2024
@zannager
Copy link
Member

zannager commented Mar 5, 2024

@MBilalShafi CLA signed, thanks.

@MBilalShafi MBilalShafi merged commit 88d5387 into mui:next Mar 12, 2024
17 checks passed
@layerok layerok deleted the header-filter-focus-loss branch April 19, 2024 16:36
@oliviertassinari oliviertassinari added plan: Pro Impact at least one Pro user and removed MUI X Pro labels Apr 26, 2024
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@layerok @MBilalShafi @thomasmoon
[DataGridPro] Add inputRef to the props passed to `colDef.renderHea…
2fc539b 
…derFilter` (mui#12328)

Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@MBilalShafi MBilalShafi MBilalShafi approved these changes

Assignees
No one assigned
Labels
CLA: signed See https://www.notion.so/mui-org/CLA-Contributor-License-Agreement-92ece655b1584b10b00e4de9e67eedb0 component: data grid This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature feature: Filtering on header Related to the header filtering (Pro) feature plan: Pro Impact at least one Pro user
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DataGrid] An input element in a custom header filter loses focus after a first letter is typed
5 participants
@layerok @mui-bot @MBilalShafi @zannager @oliviertassinari