-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Fix print export failure when hideFooter
option is set
#13034
Open
tarunrajput
wants to merge
3
commits into
mui:master
Choose a base branch
from
tarunrajput:fix/usePrintGridExport
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+12
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarunrajput
changed the title
fix: Print export fails when footer is set to hidde
[DataGrid] Print export fails when footer is set to hidde
May 6, 2024
tarunrajput
force-pushed
the
fix/usePrintGridExport
branch
from
May 6, 2024 18:20
5330d84
to
6456fda
Compare
tarunrajput
changed the title
[DataGrid] Print export fails when footer is set to hidde
[DataGrid] fix Print export fails when footer is set to hide
May 6, 2024
zannager
added
the
component: data grid
This is the name of the generic UI component, not the React module!
label
May 7, 2024
@michelengelen, mind taking a look? |
michelengelen
requested changes
May 28, 2024
packages/x-data-grid/src/hooks/features/export/useGridPrintExport.tsx
Outdated
Show resolved
Hide resolved
@cherniavskii or @MBilalShafi gentle ping on this one! |
tarunrajput
force-pushed
the
fix/usePrintGridExport
branch
from
May 28, 2024 16:35
6456fda
to
d241433
Compare
MBilalShafi
reviewed
May 31, 2024
packages/x-data-grid/src/hooks/features/export/useGridPrintExport.tsx
Outdated
Show resolved
Hide resolved
MBilalShafi
changed the title
[DataGrid] fix Print export fails when footer is set to hide
[DataGrid] Fix print export failure when May 31, 2024
hideFooter
option is set
MBilalShafi
approved these changes
Jun 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you @tarunrajput for working on it.
Deploy preview: https://deploy-preview-13034--material-ui-x.netlify.app/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #13015
When
hideFooter
option is true, grid footer is not rendered anymore. This PR adds a check to skip styling the grid footer element in that case.