-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[code-infra] Shift aliasing from babel to webpack #13051
Conversation
Deploy preview: https://deploy-preview-13051--material-ui-x.netlify.app/ |
@@ -32,6 +32,7 @@ | |||
"@mui/joy": "^5.0.0-beta.32", | |||
"@mui/lab": "^5.0.0-alpha.169", | |||
"@mui/material": "^5.15.14", | |||
"@mui/material-nextjs": "^5.15.11", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the addition needed for something? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm... But is it even needed in mui-x
? 🤔
Does removing it break something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an implicit dependency of the monorepo docs. Dependencies of @mui/monorepo/docs are not installed by package managers. Will be explicit once we move the _app.js
content to @mui/docs
.
...baseConfig.plugins, | ||
'babel-plugin-preval', | ||
[ | ||
'babel-plugin-module-resolver', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can remove this package now if it is no longer used? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's still used by some of the tests. Mocha doesn't have a straightforward way to do aliasing.
Aligning with the Toolpad and core docs