Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Shift aliasing from babel to webpack #13051

Merged
merged 6 commits into from
May 13, 2024

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented May 8, 2024

Aligning with the Toolpad and core docs

@Janpot Janpot added the scope: code-infra Specific to the core-infra product label May 8, 2024
@mui-bot
Copy link

mui-bot commented May 8, 2024

Deploy preview: https://deploy-preview-13051--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against fe3fb39

@@ -32,6 +32,7 @@
"@mui/joy": "^5.0.0-beta.32",
"@mui/lab": "^5.0.0-alpha.169",
"@mui/material": "^5.15.14",
"@mui/material-nextjs": "^5.15.11",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the addition needed for something? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... But is it even needed in mui-x? 🤔
Does removing it break something?

Copy link
Member Author

@Janpot Janpot May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an implicit dependency of the monorepo docs. Dependencies of @mui/monorepo/docs are not installed by package managers. Will be explicit once we move the _app.js content to @mui/docs.

@Janpot Janpot marked this pull request as ready for review May 8, 2024 12:00
...baseConfig.plugins,
'babel-plugin-preval',
[
'babel-plugin-module-resolver',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can remove this package now if it is no longer used? 🤔

Copy link
Member Author

@Janpot Janpot May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's still used by some of the tests. Mocha doesn't have a straightforward way to do aliasing.

@Janpot Janpot requested a review from a team May 8, 2024 13:05
@Janpot Janpot merged commit 1bdda70 into mui:master May 13, 2024
17 checks passed
@Janpot Janpot deleted the babel-aliasing branch May 13, 2024 08:18
@Janpot Janpot changed the title Shift aliasing from babel to webpack [code-infra] Shift aliasing from babel to webpack May 13, 2024
arthurbalduini pushed a commit to arthurbalduini/mui-x that referenced this pull request May 23, 2024
joakimtveter pushed a commit to joakimtveter/mui-x that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants