Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Avoid root level @mui/x-date-pickers imports #13120

Merged
merged 4 commits into from
May 14, 2024

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented May 14, 2024

Small cleanup—avoid importing from package root where possible.

@LukasTy LukasTy added core Infrastructure work going on behind the scenes component: pickers This is the name of the generic UI component, not the React module! labels May 14, 2024
@LukasTy LukasTy self-assigned this May 14, 2024
@mui-bot
Copy link

mui-bot commented May 14, 2024

Deploy preview: https://deploy-preview-13120--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 44b11b0

@LukasTy LukasTy changed the title [core] Avoid root level @mui/x-date-pickers imports [core] Avoid root level @mui/x-date-pickers imports May 14, 2024
@LukasTy LukasTy requested a review from a team May 14, 2024 07:57
Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be awesome to add a lint rule if possible

@LukasTy
Copy link
Member Author

LukasTy commented May 14, 2024

Would be awesome to add a lint rule if possible

I've tried looking into it and noticed more problems, I will solve it with a different PR.

@LukasTy LukasTy merged commit c390d16 into mui:master May 14, 2024
17 checks passed
@LukasTy LukasTy deleted the avoid-root-level-imports branch May 14, 2024 14:36
arthurbalduini pushed a commit to arthurbalduini/mui-x that referenced this pull request May 23, 2024
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants