[data grid] Update grid dimensions inside handler instead of useEffect #13231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layerok
changed the title
|
Deploy preview: https://deploy-preview-13231--material-ui-x.netlify.app/ |
oliviertassinari
added
the
component: data grid
oliviertassinari
changed the title
michelengelen
added
bug 🐛
|
I based my solution on an idea I read in the react documentation. The idea is that if useEffect doesn't clear its effects, then most likely useEffect is being used incorrectly. So I removed it and that fixed the issue, but then I saw failed tests and I realized that I hadn't taken into account that this useEffect is responsible for synchronizing the state with the props. I will try to come up with a better solution. |
|
This is not a MUI issue. It is a react-router issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13230