Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Fix mocha config to run charts tests #14041

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

alexfauquette
Copy link
Member

No description provided.

@alexfauquette alexfauquette added test component: charts This is the name of the generic UI component, not the React module! labels Jul 30, 2024
@mui-bot
Copy link

mui-bot commented Jul 30, 2024

Deploy preview: https://deploy-preview-14041--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 8edda1c

Copy link

codspeed-hq bot commented Jul 30, 2024

CodSpeed Performance Report

Congrats! CodSpeed is installed 🎉

🆕 3 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks

  • BarChart with big data amount (1.6 s)
  • LineChart with big data amount (1 s)
  • ScatterChart with big data amount (568 ms)

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 🙈
IMHO you can just merge it with Codecov error as it makes sense that the global coverage has decreased, given that Charts packages will now be added in the coverage calculation.

@alexfauquette alexfauquette merged commit 4f671ae into mui:master Jul 31, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module! test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants