[core] Fix browser tests failing on master #3817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These are the results for the performance tests:
|
3 tasks
flaviendelangle
approved these changes
Feb 2, 2022
|
😬 my bad |
|
Merging it because I have the same problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think #3593 wasn't rebased after #3774 was merged. So each PR passed the CI checks, but after merging both browser tests started to fail. https://app.circleci.com/pipelines/github/mui-org/material-ui-x/12556/workflows/bcd9e8a8-e135-47e2-90ee-aac7a9a4551c/jobs/73603
Any ideas how to avoid this kind of things? Force rebase on master before merge? I though Github bot does this automatically, but maybe it wasn't fast enough? 😀