v5.5.0 #3831
v5.5.0 #3831
Conversation
flaviendelangle
requested review from
oliviertassinari,
m4theushw,
alexfauquette,
cherniavskii and
DanailH
and removed request for
oliviertassinari and
m4theushw
|
|
||
| #### Changes | ||
|
|
||
| - [DataGrid] Add methods to import and export the state (#3593) @flaviendelangle |
There was a problem hiding this comment.
We are not advertising about that one yet
We will uncomment the doc and put it in the highlight once the column size and order are portable (see #3593 (review))
|
These are the results for the performance tests:
|
| #### Changes | ||
|
|
||
| - [DataGrid] Add methods to import and export the state (#3593) @flaviendelangle | ||
| - [DataGrid] Fix <kbd>PageUp</kbd> jumping directly to the column header skipping the first row (#3761) @cherniavskii |
There was a problem hiding this comment.
| - [DataGrid] Fix <kbd>PageUp</kbd> jumping directly to the column header skipping the first row (#3761) @cherniavskii | |
| - [DataGrid] Fix `<kbd>PageUp</kbd>` jumping directly to the column header skipping the first row (#3761) @cherniavskii |
There was a problem hiding this comment.
The others keys don't have it 😇
There was a problem hiding this comment.
The backticks override the kbd formatting: <kbd>PageUp</kbd> vs PageUp.
|
|
||
| - 🌍 Add Danish (daDK) locale (#3800) @kasperfilstrup | ||
| - 📚 Documentation improvements | ||
| - 🐞 Bugfixes | ||
|
|
||
| ### `@mui/x-data-grid@v5.5.0` / `@mui/x-data-grid-pro@v5.5.0` | ||
|
|
||
|
|
There was a problem hiding this comment.
@alexfauquette The changelog script is adding two line breaks.
There was a problem hiding this comment.
I prefer to say: "the prettier does not remove the two line breaks" ;)
The correction: #3833
| columns={columns} | ||
| groupingColDef={{ hideDescendantCount }} | ||
| /> | ||
| <DataGridPro treeData rows={rows} columns={columns} groupingColDef={{ hideDescendantCount }} /> |
There was a problem hiding this comment.
I think your prettier has modified some preview changelog
There was a problem hiding this comment.
It was @m4theushw commit but yes I suppose an update on Prettier has changed some of the behaviors
| - [l10n] Add Danish (daDK) locale (#3800) @kasperfilstrup | ||
| - [l10n] Improve Dutch (nlNL) locale (#3724) @MatthijsKok | ||
| - [l10n] Improve Hebrew (heIL) locale (#3775) @ColdAtNight | ||
| - [l10n] Improve Russian (ruRU) locale (#3818) @Leniorko |
There was a problem hiding this comment.
Would it make more sense to use the ISO name (BCP 47 language tag), than the code export name:
| - [l10n] Add Danish (daDK) locale (#3800) @kasperfilstrup | |
| - [l10n] Improve Dutch (nlNL) locale (#3724) @MatthijsKok | |
| - [l10n] Improve Hebrew (heIL) locale (#3775) @ColdAtNight | |
| - [l10n] Improve Russian (ruRU) locale (#3818) @Leniorko | |
| - [l10n] Add Danish (da-DK) locale (#3800) @kasperfilstrup | |
| - [l10n] Improve Dutch (nl-NL) locale (#3724) @MatthijsKok | |
| - [l10n] Improve Hebrew (he-IL) locale (#3775) @ColdAtNight | |
| - [l10n] Improve Russian (ru-RU) locale (#3818) @Leniorko |
There was a problem hiding this comment.
Some users use the xxXX format, other the xx-XX (the BCP 47 language tag is fancier 😆 )
I have no preference here
There was a problem hiding this comment.
For context, I was coming from this background: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/NumberFormat
console.log(new Intl.NumberFormat('de-DE', { style: 'currency', currency: 'EUR' }).format(number));The heIL seems to be more a convention that MUI has to export the locale, than the actual locale 😁.
There was a problem hiding this comment.
I agree, xxXX is just an export name.
I'll update to xx-XX in #3914
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@mui/x-license-pro", | |||
| "version": "5.4.0", | |||
| "version": "5.5.0", | |||
There was a problem hiding this comment.
Something looks broken here. There were no changes in this package, proof: v5.4.0...v5.5.0. I would expect no diffs
| "version": "5.5.0", | |
| "version": "5.4.0", |
Something is off with Lerna. It says "Bump version of packages changed since the last release": https://github.com/lerna/lerna/blob/6cb8ab2d4af7ce25c812e8fb05cd04650105705f/commands/version/README.md#lernaversion but it's not what it does, this package didn't change.
It looks like yarn lerna changed doesn't work. It's similar to lerna/lerna#2645.
$ yarn lerna changed
yarn run v1.22.17
$ /Users/oliviertassinari/mui-x/node_modules/.bin/lerna changed
lerna notice cli v4.0.0
lerna info Looking for changed packages since v4.0.0-alpha.25
WUT?
Ok, I have figured it out. Oops, check git for-each-ref refs/tags #4202.
No description provided.