Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Initialize remaining states before feature hooks #4036

Merged
merged 5 commits into from
Mar 8, 2022
Merged

[core] Initialize remaining states before feature hooks #4036

merged 5 commits into from
Mar 8, 2022

Conversation

m4theushw
Copy link
Member

@m4theushw m4theushw commented Feb 26, 2022 •
edited
Loading

In #3896 I left some states being initialized inside their feature hook. This PR changes to have all states initialized before the feature hooks. Also removes useGridStateInit.

@mui-bot
Copy link

mui-bot commented Feb 26, 2022 •
edited
Loading

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 255.8 481.3 361.2 353.8 74.784
Sort 100k rows ms 491 831.4 685.6 691.54 121.986
Select 100k rows ms 141.1 299.9 209.8 215.46 50.621
Deselect 100k rows ms 109.8 268.8 198.2 195.2 50.526

Generated by 🚫 dangerJS against f4c6afe

@m4theushw m4theushw added the core Infrastructure work going on behind the scenes label Feb 26, 2022
@m4theushw m4theushw self-assigned this Feb 28, 2022
@github-actions
Copy link

github-actions bot commented Mar 1, 2022

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 1, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 4, 2022
@github-actions
Copy link

github-actions bot commented Mar 5, 2022

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 5, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 7, 2022
@m4theushw m4theushw merged commit 1e8de15 into mui:master Mar 8, 2022
@m4theushw m4theushw deleted the initialize-state branch March 8, 2022 14:12
m4theushw added a commit to m4theushw/mui-x that referenced this pull request Mar 12, 2022
@m4theushw
Squashed commit of the following:
f293275 
commit 4dacc49
Author: Matheus Wichman <matheushw@outlook.com>
Date:   Fri Mar 11 17:01:25 2022 -0300

    yarn docs:api

commit 7ca90ca
Author: Matheus Wichman <matheushw@outlook.com>
Date:   Fri Mar 11 16:34:31 2022 -0300

    Make reason optional

commit 835c66d
Author: Matheus Wichman <matheushw@outlook.com>
Date:   Fri Mar 11 16:24:26 2022 -0300

    Remove originalRow

commit ee0b648
Author: Matheus Wichman <matheushw@outlook.com>
Date:   Fri Mar 11 16:09:29 2022 -0300

    cellToMoveFocus -> cellToFocusAfter

commit 17f3bab
Author: Matheus Wichman <matheushw@outlook.com>
Date:   Fri Mar 11 16:07:20 2022 -0300

    Fix export bug with CSB

commit d3167e0
Author: Matheus Wichman <matheushw@outlook.com>
Date:   Fri Mar 11 16:07:02 2022 -0300

    Type value with any as default

commit 1b398f6
Merge: 3540d57 949b40a
Author: Matheus Wichman <matheushw@outlook.com>
Date:   Fri Mar 11 15:55:01 2022 -0300

    Merge branch 'master' into new-editing-api

commit 949b40a
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Fri Mar 11 13:57:16 2022 -0300

    Bump actions/checkout action to v3 (mui#4107)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>

commit 50f084d
Author: Andrew Cherniavskii <andrew@mui.com>
Date:   Fri Mar 11 15:53:18 2022 +0100

    [DataGrid] Fix error overlay not visible when `autoHeight` is enabled (mui#4110)

commit 3d85cc0
Author: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Date:   Fri Mar 11 15:03:20 2022 +0100

    [DataGrid] Fix white blank when scrolling (mui#4158)

commit 19fbfa5
Author: PBM <pbmalecki@wp.pl>
Date:   Fri Mar 11 11:47:42 2022 +0100

    [l10n] add missing plPL translations (mui#4153)

commit 8b2cd47
Author: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Date:   Fri Mar 11 10:10:12 2022 +0100

    [docs] Clean ValidateRowModelControlGrid demo (mui#4073)

commit 9e2c4b4
Author: Matheus Wichman <matheushw@outlook.com>
Date:   Thu Mar 10 21:35:46 2022 -0300

    [test] Mock `getComputedStyle` to speed up unit tests (mui#4142)

commit 1922f48
Author: Matheus Wichman <matheushw@outlook.com>
Date:   Thu Mar 10 14:35:09 2022 -0300

    [test] Upgrade CircleCI convenience image (mui#4143)

commit f04331c
Author: Flavien DELANGLE <flaviendelangle@gmail.com>
Date:   Thu Mar 10 17:38:18 2022 +0100

    v5.6.1 (mui#4141)

commit 3a507bf
Author: Andrew Cherniavskii <andrew@mui.com>
Date:   Thu Mar 10 16:05:29 2022 +0100

    [core] Upgrade `@mui/monorepo` (mui#4149)

commit 37766c8
Author: Matheus Wichman <matheushw@outlook.com>
Date:   Thu Mar 10 11:29:32 2022 -0300

    [DataGrid] Rename API method (mui#4148)

commit 1ac64ba
Author: Matheus Wichman <matheushw@outlook.com>
Date:   Wed Mar 9 15:12:56 2022 -0300

    [DataGrid] Add support for margin between rows (mui#3848)

commit 5551732
Author: Matheus Wichman <matheushw@outlook.com>
Date:   Wed Mar 9 09:38:18 2022 -0300

    [test] Make focus state out-of-sync warning opt-in (mui#4129)

commit 318f6cc
Author: Flavien DELANGLE <flaviendelangle@gmail.com>
Date:   Wed Mar 9 13:20:16 2022 +0100

    [DataGridPro] Re-export the components removed by mistake during bundle split (mui#4134)

commit c886092
Author: Flavien DELANGLE <flaviendelangle@gmail.com>
Date:   Wed Mar 9 13:19:52 2022 +0100

    [core] Prepare the api build scripts for multi packages support (mui#4111)

commit d7daee6
Author: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
Date:   Wed Mar 9 11:49:38 2022 +0100

    [DataGrid] Display column's filter icon if a filter is applied (mui#4120)

commit 5e55a35
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Wed Mar 9 11:41:50 2022 +0100

    Bump MUI Core (mui#4095)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>

commit b8ed7a0
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Wed Mar 9 11:41:43 2022 +0100

    Bump css-loader to ^6.7.1 (mui#4102)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>

commit 3b34495
Author: Siriwat K <siriwatkunaporn@gmail.com>
Date:   Wed Mar 9 17:25:50 2022 +0700

    [docs] Fix links to prevent duplicate search result (mui#4130)

commit c80a645
Author: Andrew Cherniavskii <andrew@mui.com>
Date:   Wed Mar 9 10:50:15 2022 +0100

    [DataGrid] Fix extending built-in column types (mui#4114)

    Co-authored-by: Matheus Wichman <matheushw@outlook.com>

commit deb6615
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Tue Mar 8 19:33:17 2022 -0300

    Bump typescript to ^4.6.2 (mui#4104)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>

commit 1e8de15
Author: Matheus Wichman <matheushw@outlook.com>
Date:   Tue Mar 8 11:12:20 2022 -0300

    [core] Initialize remaining states before feature hooks (mui#4036)

commit fb4fc20
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Tue Mar 8 13:30:33 2022 +0100

    Bump cpy-cli to ^4.0.0 (mui#4108)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>

commit b0250ee
Author: Siriwat K <siriwatkunaporn@gmail.com>
Date:   Tue Mar 8 18:50:12 2022 +0700

    [docs] Use regex instead of specific url in e2e-website-tests (mui#4121)

commit ff35a77
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Tue Mar 8 11:21:30 2022 +0100

    Bump react-router-dom to ^6.2.2 (mui#4100)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>

commit 97e51fc
Author: Siriwat K <siriwatkunaporn@gmail.com>
Date:   Tue Mar 8 16:01:58 2022 +0700

    [docs] Neglect e2e tests related to search (mui#4118)

commit abd9bcf
Author: Olivier Tassinari <olivier.tassinari@gmail.com>
Date:   Mon Mar 7 19:56:46 2022 +0100

    [core] Make is clearer this is only for questions (mui#4082)

commit 2d1c394
Author: Vishal <32702012+patilvishal755@users.noreply.github.com>
Date:   Mon Mar 7 21:35:09 2022 +0530

    [docs] Fix outdated links to localeTextConstants.ts (mui#4080)

    Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

commit 0be075d
Author: Flavien DELANGLE <flaviendelangle@gmail.com>
Date:   Mon Mar 7 15:23:24 2022 +0100

    [DataGrid] Do not loop through rows to compute top level rows count wen the tree is flat (mui#4081)
@m4theushw m4theushw mentioned this pull request Mar 16, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviendelangle flaviendelangle flaviendelangle approved these changes

Assignees

@m4theushw m4theushw

Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m4theushw @mui-bot @flaviendelangle